-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GH Action #28
base: master
Are you sure you want to change the base?
Add GH Action #28
Conversation
Good job 👍 While reading through the code I was thinking about maybe we should make this it's own action definition, e.g. # ...
jobs:
tests:
name: Run Tests
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: digitallyinduced/test-ihp-app This way we could make updates to the github action later on easily without users manually neeeding to update this boilerplate file. There's some docs here https://docs.github.com/en/actions/creating-actions/creating-a-docker-container-action I also found it interetsing to peak in https://github.com/cachix/install-nix-action and see how it's implemented (basically an action.yaml + a shell script) |
@AronNovak ☝️ |
I started to restructure it in https://github.com/AronNovak/test-ihp-app, I'll follow-up here when we have something usable there. |
https://github.com/AronNovak/test-ihp-app works locally, but to make it a really usable custom action, I think we need to make it customizable. Docker-based GitHub actions mounts the working directory to the container, we have access to the project files. Here's my current suggestion: Does it sound good? |
How about instead of overriding, you can prepend commands? |
@amitaibu I restructured like that, but it seems we even don't need that, those manipulations in our case can be standalone commands inside the repo's actions YAML |
Allow new projects to have an already working GH action